Skip to content

cephfs: use RemoveNetworkFence directly for unfencing#6278

Merged
mergify[bot] merged 1 commit into
ceph:develfrom
Rakshith-R:mdr-cephfs-unfence
May 19, 2026
Merged

cephfs: use RemoveNetworkFence directly for unfencing#6278
mergify[bot] merged 1 commit into
ceph:develfrom
Rakshith-R:mdr-cephfs-unfence

Conversation

@Rakshith-R
Copy link
Copy Markdown
Contributor

CephFS unfencing was failing with EINVAL because
RemoveClientEviction tried to remove per-client nonce blocklist entries via go-ceph's OSDBlocklistRemove, which rejects Ceph entity address format (IP:port/nonce).

Per-client blocklist entries from MDS client eviction auto-expire and reconnecting clients get new nonces, so explicit removal is unnecessary. Call RemoveNetworkFence directly to remove only the CIDR range entry, matching the RBD unfence behavior.

Assisted-by: Claude noreply@anthropic.com

@mergify mergify Bot added the component/cephfs Issues related to CephFS label May 18, 2026
@Rakshith-R
Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 18, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 18, 2026

rebase

✅ Branch has been successfully rebased

@iPraveenParihar
Copy link
Copy Markdown
Contributor

@Mergifyio rebase

CephFS unfencing was failing with EINVAL because
RemoveClientEviction tried to remove per-client nonce
blocklist entries via go-ceph's OSDBlocklistRemove, which
rejects Ceph entity address format (IP:port/nonce).

Per-client blocklist entries from MDS client eviction
auto-expire and reconnecting clients get new nonces, so
explicit removal is unnecessary. Call RemoveNetworkFence
directly to remove only the CIDR range entry, matching the
RBD unfence behavior.

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: Rakshith R <rar@redhat.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 18, 2026

rebase

✅ Branch has been successfully rebased

@iPraveenParihar iPraveenParihar added the ci/skip/e2e skip running e2e CI jobs label May 19, 2026
@iPraveenParihar
Copy link
Copy Markdown
Contributor

@Rakshith-R
Skipping e2e as the code change is not covered in e2e suite.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 19, 2026

Deprecation notice: This pull request comes from a fork and was queued with update_method=rebase and update_bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the merge queue will no longer be able to rebase fork pull requests with this configuration. To avoid disruption, switch to update_method=merge in your queue rule.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 19, 2026

Merge Queue Status

  • Entered queue2026-05-19 05:46 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-05-19 05:46 UTC · at ec728f2645f9fbe1a5b28ceb3e34cbc33ec1c4eb · rebase

This pull request spent 13 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit 04ad9df into ceph:devel May 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip/e2e skip running e2e CI jobs component/cephfs Issues related to CephFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants