nvmeof: move QoS and host parsing into dedicated types\files.#6391
Open
gadididi wants to merge 1 commit into
Open
nvmeof: move QoS and host parsing into dedicated types\files.#6391gadididi wants to merge 1 commit into
gadididi wants to merge 1 commit into
Conversation
Move NVMe-oF QoS and host-list parsing out of the controller into dedicated package types, and split the related tests into focused files. fix issue: ceph#6302 Signed-off-by: gadi-didi <gadi.didi@ibm.com>
gadididi
force-pushed
the
nvmeof/rearrange_qos
branch
from
dfd8144 to
7e80ebf
Compare
nixpanic
approved these changes
Jul 10, 2026
nixpanic
left a comment
nixpanic
left a comment
Member
There was a problem hiding this comment.
Thanks, looks much nicer structured and maintainable this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move NVMe-oF QoS and host-list parsing out of the controller into dedicated package types,
and split the related tests into focused files.
fix issue: #6302
the issue is actually this comment from discussion_r3318503744