fix: adjust some logging and disconnect with peer when we don't have them in our local map and something is wrong (#739)

Author: dav1do

recon/src/libp2p.rs

@@ -24,7 +24,7 @@ use ceramic_core::{EventId, PeerKey};
 use futures::{future::BoxFuture, FutureExt};
 use libp2p::{
     core::ConnectedPoint,
-    swarm::{ConnectionId, NetworkBehaviour, NotifyHandler, ToSwarm},
+    swarm::{CloseConnection, ConnectionId, NetworkBehaviour, NotifyHandler, ToSwarm},
 };
 use libp2p_identity::PeerId;
 use std::{
@@ -215,7 +215,7 @@ where
     fn on_connection_handler_event(
         &mut self,
         peer_id: libp2p_identity::PeerId,
-        _connection_id: libp2p::swarm::ConnectionId,
+        connection_id: libp2p::swarm::ConnectionId,
         event: libp2p::swarm::THandlerOutEvent<Self>,
     ) {
         let ev = match event {
@@ -229,8 +229,11 @@ where
                         status: info.status,
                     })))
                 } else {
-                    tracing::warn!(%peer_id, "peer not found in peers map when started synchronizing?");
-                    None
+                    tracing::warn!(%peer_id, ?connection_id, "peer not found in peers map when started synchronizing? closing connection");
+                    Some(ToSwarm::CloseConnection {
+                        peer_id,
+                        connection: CloseConnection::One(connection_id),
+                    })
                 }
             }
 
@@ -244,8 +247,11 @@ where
                         status: info.status,
                     })))
                 } else {
-                    tracing::warn!(%peer_id, "peer not found in peers map when stopped synchronizing?");
-                    None
+                    tracing::warn!(%peer_id, ?connection_id, "peer not found in peers map when stopped synchronizing? closing connection");
+                    Some(ToSwarm::CloseConnection {
+                        peer_id,
+                        connection: CloseConnection::One(connection_id),
+                    })
                 }
             }
 
@@ -276,8 +282,11 @@ where
                         status: info.status,
                     })))
                 } else {
-                    tracing::warn!(%peer_id, "peer not found in peers map when succeeded synchronizing?");
-                    None
+                    tracing::warn!(%peer_id, ?connection_id, "peer not found in peers map when succeeded synchronizing? closing connection");
+                    Some(ToSwarm::CloseConnection {
+                        peer_id,
+                        connection: CloseConnection::One(connection_id),
+                    })
                 }
             }
 
@@ -307,8 +316,11 @@ where
                         status: info.status,
                     })))
                 } else {
-                    tracing::warn!(%peer_id, "peer not found in peers map when failed synchronizing?");
-                    None
+                    tracing::warn!(%peer_id, ?connection_id, "peer not found in peers map when failed synchronizing? closing connectoin");
+                    Some(ToSwarm::CloseConnection {
+                        peer_id,
+                        connection: CloseConnection::One(connection_id),
+                    })
                 }
             }
         };

validation/src/verifier/event_verifier.rs

@@ -3,6 +3,7 @@ use ceramic_core::Jwk;
 use ceramic_event::unvalidated::signed::{self, cacao::Capability};
 use ipld_core::ipld::Ipld;
 use ssi::{did_resolve::ResolutionInputMetadata, jws::Header};
+use tracing::debug;
 
 use super::{
     cacao_verifier::Verifier as _,
@@ -146,6 +147,13 @@ async fn resolve_did_verify_delegated(issuer: &str, delegated: &str, time: &AtTi
         .as_ref()
         .is_none_or(|c| !c.any(|c| c == delegated))
     {
+        debug!(
+            ?controller_did,
+            ?issuer,
+            ?delegated,
+            ?time,
+            "Failed to validate DID delegation"
+        );
         bail!("invalid_jws: '{delegated}' not in controllers list for issuer: '{issuer}'")
     }
     Ok(())