fix: prevent panic on duplicate tracing initialization (#718)

* fix: prevent panic on duplicate tracing initialization

* feat: test for concurrent flight-sql client init

* fix: review comment

Author: smrz2001

sdk/packages/flight-sql-client/src/lib.rs

@@ -20,7 +20,7 @@ use napi_derive::{module_exports, napi};
 use snafu::prelude::*;
 use tokio::sync::Mutex;
 use tonic::transport::Channel;
-use tracing::info;
+use tracing::{info, warn};
 use tracing_subscriber::EnvFilter;
 
 use crate::conversion::record_batches_to_buffer;
@@ -29,14 +29,19 @@ use crate::flight_client::{execute_flight, setup_client, ClientOptions};
 
 fn init_logging() {
     // Set up a subscriber that logs to stdout
-    let subscriber = tracing_subscriber::FmtSubscriber::builder()
+    if let Err(e) = tracing_subscriber::FmtSubscriber::builder()
         .with_env_filter(
             EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info")),
         )
-        .finish();
-
-    // Set the global default subscriber
-    tracing::subscriber::set_global_default(subscriber).expect("Failed to set tracing subscriber");
+        .try_init()
+    {
+        let error_msg = e.to_string();
+        if error_msg.contains("already been set") {
+            warn!("Tracing already initialized");
+        } else {
+            panic!("Failed to initialize tracing: {}", e);
+        }
+    }
 }
 
 #[module_exports]

tests/suite/src/__tests__/correctness/fast/flight-sql.test.ts

@@ -47,6 +47,53 @@ describe('flight sql', () => {
     authenticatedDID = await randomDID()
   }, 20000)
 
+  test('concurrent initialization across threads', async () => {
+    const { Worker } = await import('worker_threads');
+
+    interface WorkerMessage {
+      success: boolean;
+      error?: string;
+    }
+
+    // Create workers that will all try to load the module
+    const createWorker = (): Promise<WorkerMessage> => new Promise((resolve, reject) => {
+      const worker = new Worker(`
+      import { createFlightSqlClient } from '@ceramic-sdk/flight-sql-client';
+      import { parentPort } from 'worker_threads';
+      const OPTIONS = {
+        headers: new Array(),
+        username: undefined,
+        password: undefined,
+        token: undefined,
+        tls: false,
+        host: "",
+        port: 0,
+      }
+      try {
+        const client = createFlightSqlClient(OPTIONS);
+        parentPort.postMessage({ success: true });
+      } catch (error) {
+        parentPort.postMessage({ success: false, error: error.message });
+      }
+    `, {
+        eval: true,
+      });
+
+      worker.on('message', (data) => resolve(data as WorkerMessage));
+      worker.on('error', reject);
+    });
+
+    const results = await Promise.all([
+      createWorker(),
+      createWorker(),
+    ]);
+
+    results.forEach(result => {
+      expect(result.success).toBe(true);
+      expect(result.error).toBeUndefined();
+    });
+  });
+
   test('makes query', async () => {
     const testModel: ModelDefinition = {
       version: '2.0',