fix: prevent panic on duplicate tracing initialization#718
Merged
Conversation
stbrody
reviewed
May 16, 2025
| tracing::subscriber::set_global_default(subscriber).expect("Failed to set tracing subscriber"); | ||
| .try_init() | ||
| { | ||
| warn!("Tracing already initialized: {}", result); |
Collaborator
There was a problem hiding this comment.
do we know that the only possible error is already initialized? Is there a specific error code we can check to confirm and only swallow already initialized but Panic if there's a different type of failure?
Contributor
Author
There was a problem hiding this comment.
Good point. Updated. Though there are other ways, a string match appears to be the simplest way to check.
This was referenced May 26, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.