feat: allow configuring daemon with extra interests#734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new CLI flag
--extra-interests(and envvarCERAMIC_ONE_EXTRA_INTERESTS) to automatically register node interests when starting the daemon, eliminating the need for manual API calls after startup.Changes
--extra-interests, accepting comma-separated stream/model IDsone/src/startup.rsto orchestrate daemon configuration tasks tangential to the startup processInterestService/ceramic/interestsAPI handlerSafety & backward compatibility
Usage
Flag
Envvar
Tests
Test suite added to
one/src/startup.rs, can be run with the C1 crate:Other notes
It seems to work, but I can't say I fully understand what's going on with the interest builder EventID fencepost ranges. Probably a good spot to focus a review 👀
Closes #707