Skip to content

Commit f6d0852

Browse files
authored
[Merge] #160 - 멘토링 피드백
[Merge] #160 - 멘토링 피드백
2 parents 106d542 + 576f531 commit f6d0852

3 files changed

Lines changed: 8 additions & 24 deletions

File tree

CERTI-iOS/Presentation/Category/View/CategoryView.swift

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,8 @@ struct CategoryView: View {
2929
CategoryLicenseCardList(viewModel: viewModel)
3030
.padding(.horizontal, 20)
3131
}
32-
.onAppear {
33-
Task {
34-
await viewModel.getCategoryList()
35-
}
36-
}
37-
.onChange(of: viewModel.selectedCategory) { _ in
38-
Task{
39-
await viewModel.getCategoryList()
40-
}
32+
.task(id: viewModel.selectedCategory) {
33+
await viewModel.getCategoryList()
4134
}
4235
}
4336
}

CERTI-iOS/Presentation/CertificateDetail/View/CertificateDetailView.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,8 @@ struct CertificateDetailView: View {
134134
.frame(maxWidth: .infinity, maxHeight: .infinity)
135135
}
136136
}
137-
.onAppear {
138-
Task {
139-
await viewModel.fetchCertificateDetail(certificationId: certificationId)
140-
}
137+
.task {
138+
await viewModel.fetchCertificateDetail(certificationId: certificationId)
141139
}
142140
}
143141

CERTI-iOS/Presentation/Recommend/View/RecommendView.swift

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,11 @@ struct RecommendView: View {
2828
.presentationCornerRadius(40)
2929
.presentationDragIndicator(.hidden)
3030
}
31-
.onAppear {
32-
Task {
33-
await viewModel.getRecommendCertificationList()
34-
await viewModel.getJobList()
35-
}
31+
.task(id: viewModel.selectedJobField) {
32+
async let recommendCertificationList: () = viewModel.getRecommendCertificationList()
33+
async let jobList: () = viewModel.getJobList()
34+
_ = await (recommendCertificationList, jobList)
3635
}
37-
.onChange(of: viewModel.selectedJobField, perform: { _ in
38-
Task {
39-
await viewModel.getRecommendCertificationList()
40-
await viewModel.getJobList()
41-
}
42-
})
4336
.overlay {
4437
if viewModel.isShowLoading {
4538
CertiLoadingView(name: AuthManager.shared.nickname)

0 commit comments

Comments
 (0)