Handle conflict errors on CertificateRequest updates#447
Open
ARichman555 wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
When cert-manager updates a CertificateRequest (e.g., setting lastTransitionTime) concurrently with the aws-privateca-issuer updating the same resource, an optimistic locking conflict occurs. Previously this error bubbled up to controller-runtime, incrementing controller_runtime_reconcile_errors_total and causing false positive alerts. Now conflict errors on Update trigger a requeue without returning an error, which is the standard Kubernetes pattern for handling optimistic locking conflicts. Fixes: certificate renewal race condition causing spurious error metrics Signed-off-by: Alex Richman <wrichman@amazon.com>
ARichman555
force-pushed
the
fix-reconcile-errors
branch
from
340843d to
47d855e
Compare
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #446
Closes #446.
Reason for this change
When cert-manager updates a CertificateRequest (e.g., setting lastTransitionTime) concurrently with the aws-privateca-issuer updating the same resource, an optimistic locking conflict occurs. Previously this error bubbled up to controller-runtime, incrementing controller_runtime_reconcile_errors_total and causing false positive alerts.
Now conflict errors on Update trigger a requeue without returning an error, which is the standard Kubernetes pattern for handling optimistic locking conflicts.
Description of changes
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Re-produced using customer provided steps. I was able to confirm seeing the conflict errors in the logs were not present after making this change