Bump csi-lib to v0.10.0 and update related deps#419
Merged
cert-manager-prow[bot] merged 1 commit intoDec 10, 2025
Conversation
- Add context.Context parameter to internal csi driver.New - Propagate ctx from NewCommand to driver and underlying CSI driver - Bump dependencies (csi-lib, csi-lib-utils, otel, grpc, k8s/mount-utils) - Update LICENSES to reflect removed/updated dependency entries Signed-off-by: Richard Wall <richard.wall@cyberark.com>
cert-manager-prow
Bot
added
dco-signoff: yes
wallrj-cyberark
commented
Dec 10, 2025
| } | ||
|
|
||
| driver, err := driver.New(opts.Logr, driver.Options{ | ||
| driver, err := driver.New(ctx, opts.Logr, driver.Options{ |
Member
Author
There was a problem hiding this comment.
The csi-lib driver requires both context and logr. It doesn't use logr.FromContext.
wallrj-cyberark
commented
Dec 10, 2025
|
|
||
| // New constructs a new Driver instance. | ||
| func New(log logr.Logger, opts Options) (*Driver, error) { | ||
| func New(ctx context.Context, log logr.Logger, opts Options) (*Driver, error) { |
Member
Author
There was a problem hiding this comment.
I decided to use the same function signature as the csi-lib driver.New constructor, for consistency. But it could in future be modified to use logr.FromContext:
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual update because there's a breaking change. Originally attempted by Renovate in:
I ran
make vendor-go generateto update the LICENSES and go.sum files.Similar to the changes in csi-driver: