Skip to content

Commit 8187c64

Browse files
Merge pull request #309 from erikgb/crd-eol
Update CRD templates to ensure trailing newline
2 parents 442cb8f + 53ecb3c commit 8187c64

3 files changed

Lines changed: 2 additions & 3 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{{- end }}
1+
{{- end }}

modules/helm/crd.template.header.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ metadata:
88
helm.sh/resource-policy: keep
99
{{- end }}
1010
labels:
11-
{{- include "REPLACE_LABELS_TEMPLATE" . | nindent 4 }}
11+
{{- include "REPLACE_LABELS_TEMPLATE" . | nindent 4 }}

modules/helm/crds.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ generate-crds: | $(NEEDS_CONTROLLER-GEN) $(NEEDS_YQ)
6060
@for i in $$(ls $(crds_gen_temp)); do \
6161
crd_name=$$($(YQ) eval '.metadata.name' $(crds_gen_temp)/$$i); \
6262
cat $(crd_template_header) > $(helm_chart_source_dir)/templates/crd-$$i; \
63-
echo "" >> $(helm_chart_source_dir)/templates/crd-$$i; \
6463
$(sed_inplace) "s/REPLACE_CRD_EXPRESSION/$(crds_expression)/g" $(helm_chart_source_dir)/templates/crd-$$i; \
6564
$(sed_inplace) "s/REPLACE_CRD_NAME/$$crd_name/g" $(helm_chart_source_dir)/templates/crd-$$i; \
6665
$(sed_inplace) "s/REPLACE_LABELS_TEMPLATE/$(helm_labels_template_name)/g" $(helm_chart_source_dir)/templates/crd-$$i; \

0 commit comments

Comments
 (0)