Skip to content

Make adding annotations and labels easier#267

Merged
cert-manager-prow[bot] merged 1 commit into
mainfrom
easier_labels_and_annotations
Apr 8, 2025
Merged

Make adding annotations and labels easier#267
cert-manager-prow[bot] merged 1 commit into
mainfrom
easier_labels_and_annotations

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Apr 8, 2025

In #246, we added the options to add annotations and labels on ko images.
However, the options are hard to use and read due to comma-separated values.
Instead, providing the flag multiple times is easier and allows for cleaner makefiles.

Before:

oci_image_image_label := "org.opencontainers.image.vendor"="Vendor","org.opencontainers.image.authors"="Author","org.opencontainers.image.title"="Title"

After:

oci_image_build_args := \
	--image-label="org.opencontainers.image.vendor"="Vendor" \
	--image-label="org.opencontainers.image.authors"="Author" \
	--image-label="org.opencontainers.image.title"="Title"

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2025
Copy link
Copy Markdown
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the changes as I didn't know how to that. I'll trust you in that you have tested it with some project 😇

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@cert-manager-prow cert-manager-prow Bot merged commit edfae48 into main Apr 8, 2025
4 checks passed
@erikgb erikgb deleted the easier_labels_and_annotations branch September 14, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants