Skip to content

Revert "introduce IMAGE_ARCH"#287

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:image_variables
Apr 29, 2025
Merged

Revert "introduce IMAGE_ARCH"#287
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:image_variables

Conversation

@inteon

@inteon inteon commented Apr 29, 2025

Copy link
Copy Markdown
Member

This reverts commit 2e63fbe.

After discussing with @maelvls, it turns out that having IMAGE_ARCH is less useful than I thought (I thought it would somehow be useful for macOS users).

@cert-manager-prow cert-manager-prow Bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2025
This reverts commit 2e63fbe.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 29, 2025
@maelvls

maelvls commented Apr 29, 2025

Copy link
Copy Markdown
Member

/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@inteon

inteon commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

/approve

@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 01f8036 into cert-manager:main Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants