Fix location of licenses template#301
Merged
cert-manager-prow[bot] merged 1 commit intoJun 17, 2025
Merged
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
inteon
reviewed
Jun 17, 2025
Member
|
@SgtCoDFish I tried to make the PR more like what we already have in the repo (see https://github.com/cert-manager/makefile-modules/blob/main/modules/help/01_mod.mk#L16). |
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
force-pushed
the
licenses-tmpl-dir
branch
from
1f0694b to
48e01e4
Compare
Member
Author
|
@inteon we may have pushed at a similar time? |
Member
|
/approve Yes, but I think we had +- the same changes. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in #300 when there are nested go.mod files within a repo.
I was a little wary of referring to
make/_sharedhere but it's already referred to here:makefile-modules/modules/go/01_mod.mk
Line 33 in 7085ba6