Skip to content

update go-licenses commit to include latest bugfixes on fork#303

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:use_new_fixed_go-licenses
Jul 1, 2025
Merged

update go-licenses commit to include latest bugfixes on fork#303
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:use_new_fixed_go-licenses

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Jul 1, 2025

Updated the fork to include new fixes:
google/go-licenses@master...inteon:go-licenses:8c3708dd545a9faed3777bf50a3530ff8082180a

In short:

  • should error when one of the HTTP calls fails
  • should fix an issue where it was not detecting stdlib modules correctly

NOTE:
https://github.com/google/go-licenses does not seem to be maintained well anymore, we should maybe consider forking it in the future.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
@inteon inteon changed the title update commit to include latest bugfixes on fork update go-licenses commit to include latest bugfixes on fork Jul 1, 2025
@maelvls
Copy link
Copy Markdown
Member

maelvls commented Jul 1, 2025

Thanks for fixing these. Would be good to have a comment to remind me that this hash isn't an upstream one but rather a fork.

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@cert-manager-prow cert-manager-prow Bot merged commit ca40852 into cert-manager:main Jul 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants