Upgrade goreleaser to v2#306
Merged
Merged
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
cert-manager-prow
Bot
added
the
do-not-merge/work-in-progress
https://github.com/goreleaser/goreleaser/releases/tag/v2.11.0 Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj
commented
Jul 10, 2025
| $(YQ) 'with(.builds[]; select(.id == "$(1)") | .ldflags[1] = "-w")' | \ | ||
| $(YQ) 'with(.builds[]; select(.id == "$(1)") | .ldflags[2] = "$(go_$1_ldflags)")' | \ | ||
| $(YQ) 'with(.builds[]; select(.id == "$(1)") | .gobinary = "$(GO)")' | \ | ||
| $(YQ) 'with(.builds[]; select(.id == "$(1)") | .tool = "$(GO)")' | \ |
Member
Author
There was a problem hiding this comment.
https://goreleaser.com/deprecations/#buildsgobinary
For example:
• setting defaults
• DEPRECATED: builds.gobinary should not be used anymore, check https://goreleaser.com/deprecations#buildsgobinary for more info
Member
Author
|
/hold until I've verified this works with Gitlab based internal projects. |
cert-manager-prow
Bot
added
the
do-not-merge/hold
Member
|
/approve Thank you for upgrading this! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
Member
Author
|
Verified that it works for internal projects too. /unhold |
cert-manager-prow
Bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using a really old version of goreleaser and I hope that updating to the latest version will fix the following problems that I'm noticing with the gitlab releases for some internal CA projects:
https://github.com/goreleaser/goreleaser/releases/tag/v2.11.0
Testing
In cert-manager/cmctl#247 I created a test release:
I tested the resulting cmctl binary as follows:
curl -fsSL -O https://github.com/cert-manager/cmctl/releases/download/v2.3.0-alpha.1/cmctl_linux_amd64 chmod +x cmctl_linux_amd64 mv cmctl_linux_amd64 ~/.local/bin/ kind create cluster cmctl x install cmctl version -o yaml