Skip to content

Upgrade operator-sdk and add preflight darwin target#307

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:bump_operator_sdk
Jul 11, 2025
Merged

Upgrade operator-sdk and add preflight darwin target#307
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
inteon:bump_operator_sdk

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Jul 11, 2025

Version v1.40.0 had a replace statement, causing the installation to fail. We are now downloading the pre-built operator-sdk binaries from GitHub instead of building it using Go.

This commit also adds the darwin targets for the preflight tool, fixing a TODO comment.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2025
…operator-sdk binaries from GitHub instead of building it using Go. Building using Go was causing all kinds of issues (replace statements, library dependencies ...).

This commit also adds the darwin targets for the preflight tool, fixing a TODO comment.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the bump_operator_sdk branch from 53c59dd to 0cdf75b Compare July 11, 2025 14:08
@cert-manager-prow cert-manager-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2025
@inteon inteon changed the title Upgrade operator-sdk Upgrade operator-sdk and add preflight darwin target Jul 11, 2025
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 442cb8f into cert-manager:main Jul 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants