Skip to content

Update CRD templates to ensure trailing newline#309

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:crd-eol
Jul 17, 2025
Merged

Update CRD templates to ensure trailing newline#309
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:crd-eol

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Jul 17, 2025

Alternative to #308 to address cert-manager/cert-manager#7842 (comment).

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 17, 2025
@erikgb erikgb requested a review from inteon July 17, 2025 12:37
@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2025
Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 8187c64 into cert-manager:main Jul 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants