Allow for excluding CRD template files#311
Merged
cert-manager-prow[bot] merged 1 commit intoJul 22, 2025
Merged
Conversation
cert-manager-prow
Bot
added
do-not-merge/work-in-progress
erikgb
force-pushed
the
crd-template-exclude
branch
3 times, most recently
from
b4d7cfd to
c0906e6
Compare
cert-manager-prow
Bot
added
size/M
erikgb
force-pushed
the
crd-template-exclude
branch
3 times, most recently
from
2206eea to
9c28a33
Compare
erikgb
changed the title
cert-manager-prow
Bot
removed
the
do-not-merge/work-in-progress
inteon
reviewed
Jul 22, 2025
erikgb
force-pushed
the
crd-template-exclude
branch
from
9c28a33 to
50ef480
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
crd-template-exclude
branch
from
50ef480 to
e287a60
Compare
inteon
reviewed
Jul 22, 2025
| # Space-separated list of basenames to exclude (e.g. foo.yaml *_test.yaml) | ||
| crds_template_exclude_pattern ?= | ||
|
|
||
| define filter-out-basenames |
Member
There was a problem hiding this comment.
I don't understand how this works, but I trust you that it works.
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new feature to the Helm module, allowing exclusion of CRD(s) from getting included into the Helm chart. This feature is needed to avoid introducing the
ClusterBundleAPI prematurely in trust-manger, ref. cert-manager/trust-manager#662.Generating the CRD will allow me to start working on validation, including tests, for the new API. But at the same time, avoiding the new CRD from being available to users.