Allow custom orgs for running govulncheck jobs#314
Merged
cert-manager-prow[bot] merged 1 commit intoAug 5, 2025
Conversation
Repos outside the cert-manager org might want to use the govulncheck job; this could be other repos depending on makefile-modules, or forks of cert-manager org repos who want to run the job. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Member
|
Similar challenges apply to . |
maelvls
approved these changes
Aug 5, 2025
Member
maelvls
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for testing this with trust-manager and showing the diff!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SgtCoDFish
added a commit
to jetstack/jetstack-secure
that referenced
this pull request
Aug 5, 2025
Previously the org name was hardcoded to "cert-manager" which prevented the govulncheck Action being run on this repo. This commit does a manual makefile modules upgrade to adopt the latest changes after [0] merged, which should re-enable the govulncheck job. [0]: cert-manager/makefile-modules#314 Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repos outside the cert-manager org might want to use the govulncheck job; this could be other repos depending on makefile-modules, or forks of cert-manager org repos who want to run the job.
By setting
govulncheck_generate_orginmake/00_mod.mkusers of makefile-modules will be able to use a custom org.This does also change the
generate-govulncheckjob to only copy the govulncheck workflow file, rather than copying the wholemodules/go/basedirectory, but the govulncheck file was the only one in that repo anyway (and it would be confusing to copy other files in a target calledgenerate-govulncheck)Testing
I've tested this with a local copy of trust-manager pointing at this branch and it worked as expected. Diff: