Improve error message for helm chart version#320
Merged
cert-manager-prow[bot] merged 1 commit intoAug 11, 2025
Conversation
cert-manager-prow
Bot
added
the
dco-signoff: yes
The following error is common if a repo does not locally contain any tags: ```console $ make test-e2e make/_shared/helm///helm.mk:35: *** helm_chart_version "1bdf96cfeb0fa2-dirty" should start with a "v". Stop. ``` This is because makefile-modules uses tag-based logic to determine the chart version. Without tags, it defaults to a hash which fails the check edited by this commit. This commit adds a hint about pulling remote tags to help users diagnose this issue and fix it. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
force-pushed
the
helm-chart-version-warn
branch
from
f00a85e to
655d43c
Compare
cert-manager-prow
Bot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following error is common if a repo does not locally contain any tags:
This is because makefile-modules uses tag-based logic to determine the chart version. Without tags, it defaults to a hash which fails the check edited by this commit.
This commit adds a hint about pulling remote tags to help users diagnose this issue and fix it.
I tested this locally and it produced the error as expected (I was just checking for like syntax errors or something like that):