Skip to content

Move LICENSE file to boilerplate module#329

Merged
cert-manager-prow[bot] merged 1 commit into
mainfrom
move_license
Aug 22, 2025
Merged

Move LICENSE file to boilerplate module#329
cert-manager-prow[bot] merged 1 commit into
mainfrom
move_license

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Aug 21, 2025

This file fits the boilerplate module which checks for Apache-2.0 headers.
It allows users to use the repository-base module for non-Apache-2.0 repos.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2025
Copy link
Copy Markdown
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this, won't it cause all the nightly makefile module updates to remove the LICENSE from open-source projects, because it is no longer in the repository base?

Have you tested it from another repo?

Merge if you're confident that it's not going to cause mayhem over the weekend.

@inteon
Copy link
Copy Markdown
Member Author

inteon commented Aug 22, 2025

If we merge this, won't it cause all the nightly makefile module updates to remove the LICENSE from open-source projects, because it is no longer in the repository base?

Have you tested it from another repo?

Merge if you're confident that it's not going to cause mayhem over the weekend.

All these projects also have the boilerplate module that now houses this LICENSE file.
It will only change projects that don't have the boilerplate module, which are non of the OSS projects.

@inteon
Copy link
Copy Markdown
Member Author

inteon commented Aug 22, 2025

/approve

@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj-cyberark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2025
@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2025
@cert-manager-prow cert-manager-prow Bot merged commit dbdedf5 into main Aug 22, 2025
4 checks passed
@erikgb erikgb deleted the move_license branch September 14, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants