Skip to content

Make golangci-lint required #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cert-manager-prow merged 1 commit into from
Aug 21, 2025
Merged

Make golangci-lint required #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/go/01_mod.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ ifndef repo_name
$(error repo_name is not set)
endif

ifndef golangci_lint_config
$(error golangci_lint_config is not set)
endif

golangci_lint_override := $(dir $(lastword $(MAKEFILE_LIST)))/.golangci.override.yaml

.PHONY: go-workspace
Expand Down Expand Up @@ -105,7 +109,6 @@ verify-govulncheck: | $(NEEDS_GOVULNCHECK)

endif # govulncheck_skip

ifdef golangci_lint_config

.PHONY: generate-golangci-lint-config
## Generate a golangci-lint configuration file
Expand Down Expand Up @@ -155,5 +158,3 @@ fix-golangci-lint: | $(NEEDS_GOLANGCI-LINT) $(NEEDS_YQ) $(NEEDS_GCI) $(bin_dir)/
popd >/dev/null; \
echo ""; \
done

endif
Loading