adding helm-unittest plugin binary

[hjoshi123]

This PR adds makefile targets to use the helm plugin helm-unittest. It doesn't directly use the helm plugin install command instead it downloads the binary behind the plugin and consumes that to run the helm unit tests. This is a much safer way to do it in my opinion as we can target a specific version of the binary through github releases and also use renovate to upgrade the version.

[erikgb]

@hjoshi123, thanks for this, but I think something is missing here. When I tested your branch in trust-manager, without any additional changes, I get a lot of errors in the build logs:

make/_shared/helm///helm.mk:121: warning: undefined variable 'NEEDS_HELM-UNITTEST'
/home/erikbo/projects/github/trust-manager/_bin/tools/boilersuite .
make/_shared/generate-verify//util/verify.sh make generate-applyconfigurations
make[1]: Entering directory '/tmp/verify.sh.NENz9LmG'

[hjoshi123]

@erikgb was the tools makefile copied too?

[erikgb]

@erikgb was the tools makefile copied too?

Ahhh, I need to update both the helm AND the tools module. Then it works! Sorry!

$ make verify-helm-unittest 
/home/erikbo/projects/github/trust-manager/_bin/tools/yq '.annotations."artifacthub.io/prerelease" = "false"' --inplace deploy/charts/trust-manager/Chart.yaml
/home/erikbo/projects/github/trust-manager/_bin/tools/helm-unittest deploy/charts/trust-manager

### Chart [ trust-manager ] deploy/charts/trust-manager


Charts:      1 passed, 1 total
Test Suites: 0 passed, 0 total
Tests:       0 passed, 0 total
Snapshot:    0 passed, 0 total
Time:        1.41308ms

[erikgb]

Thanks for working on this, @hjoshi123! I have tested that this change doesn't break anything, ref. the comment above. And merging this will allow you to continue your work.

/lgtm
/approve

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [erikgb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hjoshi123]

I did notice one thing though, in cert-manager we dont include the helm.mk file in the root makefile.. so we might have to manually add the target in ci.mk probably

[erikgb]

I did notice one thing though, in cert-manager we dont include the helm.mk file in the root makefile.. so we might have to manually add the target in ci.mk probably

Maybe cert-manager doesn't use the Helm module yet? It would be great to let cert-manager use more makefile-modules.

[hjoshi123]

I did notice one thing though, in cert-manager we dont include the helm.mk file in the root makefile.. so we might have to manually add the target in ci.mk probably

Maybe cert-manager doesn't use the Helm module yet? It would be great to let cert-manager use more makefile-modules.

Yeah they do clone it in _shared_new but only include certain makefiles inside it.. yeah it might be worth to include them now that we have a usecase.