Skip to content

Remove explicitly enabled managers#577

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:remove-enabled-managers
Apr 5, 2026
Merged

Remove explicitly enabled managers#577
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:remove-enabled-managers

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Apr 5, 2026

This removes the list of explicitly enabled Renovate managers. AFAIK, all managers should be enabled by default, and I suspect this list might be the reason why cert-manager/trust-manager#924 doesn't work.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb requested a review from Copilot April 5, 2026 14:37
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the explicit enabledManagers allowlist from Renovate configuration so Renovate can use its default set of enabled managers, which may resolve missed updates (e.g., the referenced Renovate PR not being created).

Changes:

  • Deleted the enabledManagers array from .github/renovate.json5, removing the explicit manager restriction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 5, 2026

/cc @ThatsMrTalbot

@ThatsMrTalbot
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2026
@cert-manager-prow cert-manager-prow Bot merged commit f45c08b into cert-manager:main Apr 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants