Remove verify-helm-unittest side effect#581
Remove verify-helm-unittest side effect#581cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
Conversation
cert-manager-prow
bot
added
the
dco-signoff: yes
cert-manager-prow
bot
added
the
size/XS
There was a problem hiding this comment.
Pull request overview
Removes an unintended side effect from the verify-helm-unittest make target so running Helm unit tests does not mutate the chart’s Chart.yaml.
Changes:
- Removed the
yqin-place edit that was settingartifacthub.io/prereleaseduringverify-helm-unittest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
remove-helm-unit-side-effect
branch
from
8848b36 to
4238187
Compare
|
/cc @hjoshi123 @inteon |
|
/approve @erikgb could you verify that none of our repos had this field set accidentally? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sure! |
|
It seems like it didn't manage to change anything, ref. https://github.com/search?q=org%3Acert-manager+artifacthub.io%2Fprerelease+path%3A%2F%5Edeploy%5C%2Fcharts%5C%2F%2F&type=code That would anyway be blocked by the failing |
#576 introduces a side-effect causing issues in some of our projects. Example: cert-manager/google-cas-issuer#471
I don't see why the side-effect is required to run the Helm unit tests.