Add generated CRD for new ClusterBundle API#662
Merged
cert-manager-prow[bot] merged 1 commit intoJul 22, 2025
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
erikgb
force-pushed
the
clusterbundle-crd
branch
from
7ce7666 to
c887f41
Compare
cert-manager-prow
Bot
added
size/L
erikgb
changed the title
cert-manager-prow
Bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
clusterbundle-crd
branch
from
261aa32 to
2e40bca
Compare
erikgb
changed the title
cert-manager-prow
Bot
removed
the
do-not-merge/work-in-progress
SgtCoDFish
approved these changes
Jul 22, 2025
Member
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Erik explained in standup this morning that this step would help with development of the new ClusterBundle. Looks great to me!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds generated CRDs for the new ClusterBundle API, ref. #485. Since controller-gen does not allow me to generate a CRD without a served version, I had to add a dummy v1alpha served version. This is not optimal, but generating the CRD will allow me to continue adding API validations. UPDATE: I created a PR for a new feature in makefile-modules helm module to allow me to exclude CRD templates from the Helm chart, which I think is a good/better workaround: cert-manager/makefile-modules#311