docs: add ACK RRSA supported AliDNS webhook #1909
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,6 +162,7 @@ Links to these supported providers along with their documentation are below: | |
| - [`AliDNS-Webhook`](https://github.com/pragkent/alidns-webhook) | ||
| - [`bizflycloud-certmanager-dns-webhook`](https://github.com/bizflycloud/bizflycloud-certmanager-dns-webhook) | ||
| - [`cert-manager-alidns-webhook`](https://github.com/DEVmachine-fr/cert-manager-alidns-webhook) | ||
| - [`cert-manager-alidns-webhook`](https://github.com/crazygit/cert-manager-alidns-webhook)(Suport ACK RRSA) | ||
|
Member
There was a problem hiding this comment. This would create two identically named entries ( More importantly, the feature you built (RRSA/default credential chain support) is already the subject of open PRs on the DEVmachine-fr webhook: #29 and #37. Contributing there would benefit the 158+ users already using that webhook, rather than asking them to migrate to a new project. Also a minor point: "Suport" is a typo for "Support". |
||
| - [`cert-manager-webhook-abion`](https://github.com/abiondevelopment/cert-manager-webhook-abion) | ||
| - [`cert-manager-webhook-arvan`](https://github.com/kiandigital/cert-manager-webhook-arvan) | ||
| - [`cert-manager-webhook-civo`](https://github.com/okteto/cert-manager-webhook-civo) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit odd. I am no expert on AliDNS, but why didn't you contribute "ACK RRSA" to the AliDNS webhook linked in the line above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikgb Thanks for the question — I agree it’s important to avoid unnecessary duplication.
What’s different here: this repo is designed around ACK RRSA / OIDC and the Alibaba Cloud SDK default credential chain, so authentication happens on the webhook side without putting AK/SK into Issuer secrets. The existing AliDNS webhook is AK/SK‑based, configured via Issuer secrets, so the auth model is quite different.
Why I didn’t submit to the other repo: adding RRSA support there would likely be more than a small patch — it would involve changes to the auth flow, config schema, and docs, and I wanted to avoid disrupting existing AK/SK users. I also wanted to keep the RRSA‑first approach focused and clear, since it targets newer cert-manager versions and the ACK RRSA identity scenario specifically.
Thanks for considering this and for the review.