feat: go to symbol now goes to character instead of line

e.g for `public void method()` the cursor goes before method.
It makes it easier to spot the selected symbol.

Author: lukecotter

lana/src/display/OpenFileInPackage.ts

@@ -22,10 +22,9 @@ export class OpenFileInPackage {
       return;
     }
 
-    const parts = symbolName.split('.');
-    const fileName = parts[0]?.trim();
+    const parts = symbolName.slice(0, symbolName.indexOf('('));
 
-    const paths = await context.findSymbol(fileName as string);
+    const paths = await context.findSymbol(parts);
     if (!paths.length) {
       return;
     }
@@ -59,16 +58,17 @@ export class OpenFileInPackage {
 
     const parsedRoot = parseApex(document.getText());
 
-    const symbolLocation = getMethodLine(parsedRoot, parts);
+    const symbolLocation = getMethodLine(parsedRoot, symbolName);
 
     if (!symbolLocation.isExactMatch) {
       context.display.showErrorMessage(
         `Symbol '${symbolLocation.missingSymbol}' could not be found in file '${basename(path)}'`,
       );
     }
     const zeroIndexedLineNumber = symbolLocation.line - 1;
+    const character = symbolLocation.character ?? 0;
 
-    const pos = new Position(zeroIndexedLineNumber, 0);
+    const pos = new Position(zeroIndexedLineNumber, character);
 
     const options: TextDocumentShowOptions = {
       preserveFocus: false,

lana/src/salesforce/ApexParser/ApexSymbolLocator.ts

@@ -11,6 +11,7 @@ import { CharStreams } from 'antlr4ts';
 import { ApexVisitor, type ApexMethodNode, type ApexNode } from './ApexVisitor';
 
 export type SymbolLocation = {
+  character: number;
   line: number;
   isExactMatch: boolean;
   missingSymbol?: string;
@@ -26,7 +27,7 @@ export function parseApex(apexCode: string): ApexNode {
 }
 
 export function getMethodLine(rootNode: ApexNode, symbols: string[]): SymbolLocation {
-  const result: SymbolLocation = { line: 1, isExactMatch: true };
+  const result: SymbolLocation = { character: 0, line: 1, isExactMatch: true };
 
   if (symbols[0] === rootNode.name) {
     symbols = symbols.slice(1);
@@ -52,12 +53,14 @@ export function getMethodLine(rootNode: ApexNode, symbols: string[]): SymbolLoca
 
       if (!methodNode) {
         result.line = currentRoot.line ?? 1;
+        result.character = currentRoot.idCharacter ?? 0;
         result.isExactMatch = false;
         result.missingSymbol = symbol;
         break;
       }
 
       result.line = methodNode.line;
+      result.character = methodNode.idCharacter;
     }
   }
 

lana/src/salesforce/ApexParser/ApexVisitor.ts

@@ -11,18 +11,50 @@ import type { ErrorNode, ParseTree, RuleNode, TerminalNode } from 'antlr4ts/tree
 
 type ApexNature = 'Class' | 'Method';
 
+/**
+ * Represents a node in the Apex syntax tree.
+ * Can be either a class or method declaration with optional child nodes.
+ */
 export interface ApexNode {
+  /** The type of Apex construct (Class or Method) */
   nature?: ApexNature;
+  /** The name of the class or method */
   name?: string;
+  /** Child nodes (nested classes or methods) */
   children?: ApexNode[];
+  /** Line number where the node is declared */
   line?: number;
+  /** Character position of the identifier on the line */
+  idCharacter?: number;
+}
+
+/**
+ * Represents a class declaration node in the Apex syntax tree.
+ * All properties are required (non-optional) to ensure complete class metadata.
+ */
+export interface ApexClassNode extends ApexNode {
+  /** Indicates this node represents a class declaration */
+  nature: 'Class';
+  /** Line number where the class is declared */
+  line: number;
+  /** Character position of the class identifier on the line */
+  idCharacter: number;
 }
 
-export type ApexMethodNode = ApexNode & {
+/**
+ * Represents a method declaration node in the Apex syntax tree.
+ * All properties are required (non-optional) to ensure complete method metadata.
+ */
+export interface ApexMethodNode extends ApexNode {
+  /** Indicates this node represents a method declaration */
   nature: 'Method';
+  /** Comma-separated list of parameter types for the method */
   params: string;
+  /** Line number where the method is declared */
   line: number;
-};
+  /** Character position of the method identifier on the line */
+  idCharacter: number;
+}
 
 type VisitableApex = ParseTree & {
   accept<Result>(visitor: ApexParserVisitor<Result>): Result;
@@ -49,22 +81,30 @@ export class ApexVisitor implements ApexParserVisitor<ApexNode> {
     return { children };
   }
 
-  visitClassDeclaration(ctx: ClassDeclarationContext): ApexNode {
+  visitClassDeclaration(ctx: ClassDeclarationContext): ApexClassNode {
+    const { start } = ctx;
+    const ident = ctx.id();
+
     return {
       nature: 'Class',
       name: ctx.id().Identifier()?.toString() ?? '',
       children: ctx.children?.length ? this.visitChildren(ctx).children : [],
-      line: ctx.start.line,
+      line: start.line,
+      idCharacter: ident.start.charPositionInLine ?? 0,
     };
   }
 
   visitMethodDeclaration(ctx: MethodDeclarationContext): ApexMethodNode {
+    const { start } = ctx;
+    const ident = ctx.id();
+
     return {
       nature: 'Method',
       name: ctx.id().Identifier()?.toString() ?? '',
       children: ctx.children?.length ? this.visitChildren(ctx).children : [],
       params: this.getParameters(ctx.formalParameters()),
-      line: ctx.start.line,
+      line: start.line,
+      idCharacter: ident.start.charPositionInLine,
     };
   }