refactor: avoid auto focusing the table when a row is expanded or collapsed

lukecotter · lukecotter · commit d7c5177d8cc6 · 2025-04-17T10:47:45.000+01:00
diff --git a/log-viewer/modules/datagrid/module/RowKeyboardNavigation.ts b/log-viewer/modules/datagrid/module/RowKeyboardNavigation.ts
@@ -48,13 +48,10 @@ export class RowKeyboardNavigation extends Module {
 
   rowExpandedToggled(row: RowComponent, _level: number) {
     const table = row.getTable();
-    this.tableHolder ??= table.element.querySelector('.tabulator-tableholder') as HTMLElement;
-
-    const selectedRow = table.getSelectedRows()[0];
-    if (!selectedRow) {
+    const selectedRows = table.getSelectedRows();
+    if (!selectedRows.length) {
       row.select();
     }
-    this.tableHolder?.focus();
   }
 
   rowClick(event: UIEvent, row: RowComponent) {

Original file line number	Diff line number	Diff line change
`@@ -48,13 +48,10 @@ export class RowKeyboardNavigation extends Module {`
`48`	`48`
`49`	`49`	`rowExpandedToggled(row: RowComponent, _level: number) {`
`50`	`50`	`const table = row.getTable();`
`51`		`- this.tableHolder ??= table.element.querySelector('.tabulator-tableholder') as HTMLElement;`
`52`		`-`
`53`		`- const selectedRow = table.getSelectedRows()[0];`
`54`		`- if (!selectedRow) {`
	`51`	`+ const selectedRows = table.getSelectedRows();`
	`52`	`+ if (!selectedRows.length) {`
`55`	`53`	`row.select();`
`56`	`54`	`}`
`57`		`- this.tableHolder?.focus();`
`58`	`55`	`}`
`59`	`56`
`60`	`57`	`rowClick(event: UIEvent, row: RowComponent) {`