Merge pull request #591 from lukecotter/bug-analysis-scroll-disappearing

fix: analysis table table vanishing on scroll drag

Author: lcottercertinia

CHANGELOG.md

@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Call Tree: Performance regression of Call Tree rendering ([#581][#581]).
 - Call Tree: Call Tree not correctly keeping position when rows where hidden / shown via Details and Debug Only ([#581][#581]).
 - Database: Call stack shows items horizontally instead of vertically ([#582][#582])
+- Analysis: Sometimes disappered when dragging the scroll bar down, sorry about that. ([#590])
 
 ## [1.16.1] - 2024-12-03
 
@@ -386,6 +387,7 @@ Skipped due to adopting odd numbering for pre releases and even number for relea
 [#588]: https://github.com/certinia/debug-log-analyzer/issues/588
 [#583]: https://github.com/certinia/debug-log-analyzer/issues/583
 [#589]: https://github.com/certinia/debug-log-analyzer/issues/589
+[#590]: https://github.com/certinia/debug-log-analyzer/issues/590
 
 <!-- 1.16.1 -->
 

log-viewer/modules/components/analysis-view/AnalysisView.ts

@@ -50,14 +50,32 @@ export class AnalysisView extends LitElement {
         height: 100%;
         width: 100%;
         display: flex;
-        flex-direction: column;
-        flex: 1;
         gap: 1rem;
       }
 
+      .analysis-view {
+        display: flex;
+        flex-direction: column;
+        height: 100%;
+        width: 100%;
+      }
+
       #analysis-table-container {
-        display: contents;
         height: 100%;
+        width: 100%;
+        min-height: 0;
+        min-width: 0;
+      }
+
+      #analysis-table {
+        display: inline-block;
+        height: 100%;
+        width: 100%;
+      }
+
+      .filter-container {
+        display: flex;
+        gap: 5px;
       }
 
       .dropdown-container {
@@ -114,39 +132,41 @@ export class AnalysisView extends LitElement {
     const skeleton = !this.timelineRoot ? html`<grid-skeleton></grid-skeleton>` : '';
 
     return html`
-      <datagrid-filter-bar>
-        <div slot="filters" class="dropdown-container">
-          <label for="groupby-dropdown"><strong>Group by</strong></label>
-          <vscode-dropdown id="groupby-dropdown" @change="${this._groupBy}">
-            <vscode-option>None</vscode-option>
-            <vscode-option>Namespace</vscode-option>
-            <vscode-option>Type</vscode-option>
-          </vscode-dropdown>
-        </div>
-
-        <div slot="actions">
-          <vscode-button
-            appearance="icon"
-            aria-label="Export to CSV"
-            title="Export to CSV"
-            @click=${this._exportToCSV}
-          >
-            <span class="codicon codicon-desktop-download"></span>
-          </vscode-button>
-          <vscode-button
-            appearance="icon"
-            aria-label="Copy to clipboard"
-            title="Copy to clipboard"
-            @click=${this._copyToClipboard}
-          >
-            <span class="codicon codicon-copy"></span>
-          </vscode-button>
+      <div class="analysis-view">
+        <datagrid-filter-bar>
+          <div slot="filters" class="dropdown-container">
+            <label for="groupby-dropdown"><strong>Group by</strong></label>
+            <vscode-dropdown id="groupby-dropdown" @change="${this._groupBy}">
+              <vscode-option>None</vscode-option>
+              <vscode-option>Namespace</vscode-option>
+              <vscode-option>Type</vscode-option>
+            </vscode-dropdown>
+          </div>
+
+          <div slot="actions">
+            <vscode-button
+              appearance="icon"
+              aria-label="Export to CSV"
+              title="Export to CSV"
+              @click=${this._exportToCSV}
+            >
+              <span class="codicon codicon-desktop-download"></span>
+            </vscode-button>
+            <vscode-button
+              appearance="icon"
+              aria-label="Copy to clipboard"
+              title="Copy to clipboard"
+              @click=${this._copyToClipboard}
+            >
+              <span class="codicon codicon-copy"></span>
+            </vscode-button>
+          </div>
+        </datagrid-filter-bar>
+
+        <div id="analysis-table-container">
+          ${skeleton}
+          <div id="analysis-table"></div>
         </div>
-      </datagrid-filter-bar>
-
-      <div id="analysis-table-container">
-        ${skeleton}
-        <div id="analysis-table"></div>
       </div>
     `;
   }
@@ -257,6 +277,7 @@ export class AnalysisView extends LitElement {
 
         return new Blob([fileContents], { type: mimeType });
       },
+      dataTree: true, // temporary: fixes a disappearing table issue when scroll is dragged (needs fix in Tabulator)
       downloadRowRange: 'all',
       downloadConfig: {
         columnHeaders: true,
@@ -269,6 +290,7 @@ export class AnalysisView extends LitElement {
       keybindings: { copyToClipboard: ['ctrl + 67', 'meta + 67'] },
       clipboardCopyRowRange: 'all',
       height: '100%',
+      maxHeight: '100%',
       groupCalcs: true,
       groupClosedShowCalcs: true,
       groupStartOpen: false,
@@ -325,6 +347,7 @@ export class AnalysisView extends LitElement {
             multiselect: true,
           },
           headerFilterLiveFilter: false,
+          variableHeight: true,
         },
         {
           title: 'Type',

log-viewer/modules/components/calltree-view/CalltreeView.ts

@@ -110,18 +110,19 @@ export class CalltreeView extends LitElement {
         flex-direction: column;
         height: 100%;
         width: 100%;
-        min-height: 0;
-        min-width: 0;
       }
 
       #call-tree-table-container {
         height: 100%;
-        flex-grow: 1;
+        width: 100%;
         min-height: 0;
+        min-width: 0;
       }
 
       #call-tree-table {
+        display: inline-block;
         height: 100%;
+        width: 100%;
       }
 
       .header-bar {