perf: monomorphic logevent#575
Merged
lcottercertinia merged 27 commits intocertinia:mainfrom Aug 28, 2025
Merged
Conversation
- Use a single while loop instead of 2 + removes len decrement - Remove the need for Map to represent levels
Pipes the fetch repsonsse through TextDecoderStream. We still read the full log content into memory but we do not block the main thread. It also open up a migration to reading the log line by line later instead of all into memory which will help with memory.
- ApexLogParser.ts - Main parser logic - LogEvents.ts - All log event classes - LogLineMapping.ts - Mapping of log event types to classes - types.ts - Types and interfaces
Collaborator
|
Some changes have moved to #612. |
lukecotter
force-pushed
the
perf-monomorphic-logevent
branch
2 times, most recently
from
90a165b to
5fde7a1
Compare
lukecotter
force-pushed
the
perf-monomorphic-logevent
branch
from
1ec0544 to
4cd7dcb
Compare
lcottercertinia
previously approved these changes
Aug 28, 2025
lcottercertinia
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to improve Log Parser performance, primarily through ensuring objects are monomorphic which helps engines optimise especially in tight loops.
It will also address some other performance improvements and restructure the files e.g separate file for the types
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
resolves #552
Related Issue #
fixes #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?