fix: calltree expand performance regression due to search recursion#621
Merged
lcottercertinia merged 3 commits intoMay 11, 2025
Merged
Conversation
lcottercertinia
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
The search logic in the grid was causing an infinite loop when calling expand/ collapse all on calltree.
The find search handling has been refactored to block clearing search highlights when search is happening and only clear if a rerender occurs and no search is currently active.
This means search highlights only clear when grouping, sorting etc (anything the causes a render other than search).
🛠️ Changes made
🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
Show off your UI changes.
🔗 Related Issues
fixes #
resolves #
closes #
related #581
✅ Tests added?
📚 Docs updated?
Anything else we need to know? [optional]