Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

/**
* Unit tests for SelectionManager
* Unit tests for SelectionNavigator
*
* Tests selection state management and navigation:
* - select/clear/getSelected lifecycle
Expand All @@ -16,11 +16,11 @@
* - findByOriginal for hit test integration
*/

import { SelectionManager } from '../optimised/selection/SelectionManager.js';
import { SelectionNavigator } from '../optimised/selection/SelectionNavigator.js';
import type { EventNode, TreeNode } from '../types/flamechart.types.js';
import type { NavigationMaps } from '../utils/tree-converter.js';

describe('SelectionManager', () => {
describe('SelectionNavigator', () => {
/**
* Helper to create a mock EventNode
*/
Expand Down Expand Up @@ -97,15 +97,15 @@ describe('SelectionManager', () => {
}

describe('selection lifecycle', () => {
let manager: SelectionManager<EventNode>;
let manager: SelectionNavigator<EventNode>;
let node1: TreeNode<EventNode>;
let node2: TreeNode<EventNode>;

beforeEach(() => {
node1 = createNode(createEvent('1'));
node2 = createNode(createEvent('2'));
const rootNodes = [node1, node2];
manager = new SelectionManager(rootNodes, buildMapsFromNodes(rootNodes));
manager = new SelectionNavigator(rootNodes, buildMapsFromNodes(rootNodes));
});

it('should have no selection initially', () => {
Expand Down Expand Up @@ -152,7 +152,7 @@ describe('SelectionManager', () => {
// └── child2 (id: 12)
// root2 (id: 2)

let manager: SelectionManager<EventNode>;
let manager: SelectionNavigator<EventNode>;
let root1: TreeNode<EventNode>;
let root2: TreeNode<EventNode>;
let child1: TreeNode<EventNode>;
Expand All @@ -167,7 +167,7 @@ describe('SelectionManager', () => {
root2 = createNode(createEvent('2'), undefined, 0);

const rootNodes = [root1, root2];
manager = new SelectionManager(rootNodes, buildMapsFromNodes(rootNodes));
manager = new SelectionNavigator(rootNodes, buildMapsFromNodes(rootNodes));
});

it('should return null when navigating with no selection', () => {
Expand Down Expand Up @@ -275,7 +275,7 @@ describe('SelectionManager', () => {
});

describe('findById', () => {
let manager: SelectionManager<EventNode>;
let manager: SelectionNavigator<EventNode>;
let node1: TreeNode<EventNode>;
let node2: TreeNode<EventNode>;

Expand All @@ -284,7 +284,7 @@ describe('SelectionManager', () => {
node1 = createNode(createEvent('1'), [child], 0);
node2 = createNode(createEvent('2'), undefined, 0);
const rootNodes = [node1, node2];
manager = new SelectionManager(rootNodes, buildMapsFromNodes(rootNodes));
manager = new SelectionNavigator(rootNodes, buildMapsFromNodes(rootNodes));
});

it('should find node by id', () => {
Expand All @@ -306,7 +306,7 @@ describe('SelectionManager', () => {
describe('empty tree', () => {
it('should handle empty tree', () => {
const rootNodes: TreeNode<EventNode>[] = [];
const manager = new SelectionManager<EventNode>(rootNodes, buildMapsFromNodes(rootNodes));
const manager = new SelectionNavigator<EventNode>(rootNodes, buildMapsFromNodes(rootNodes));

expect(manager.hasSelection()).toBe(false);
expect(manager.getSelected()).toBeNull();
Expand Down
6 changes: 3 additions & 3 deletions log-viewer/src/features/timeline/__tests__/batching.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
import type { LogCategory, LogEvent } from 'apex-log-parser';
import * as PIXI from 'pixi.js';
import { EventBatchRenderer } from '../optimised/EventBatchRenderer.js';
import { RectangleManager } from '../optimised/RectangleManager.js';
import { RectangleCache } from '../optimised/RectangleCache.js';
import type { RenderBatch, ViewportState } from '../types/flamechart.types.js';
import { TIMELINE_CONSTANTS } from '../types/flamechart.types.js';

describe('EventBatchRenderer', () => {
let container: PIXI.Container;
let renderer: EventBatchRenderer;
let rectangleManager: RectangleManager;
let rectangleManager: RectangleCache;
let batches: Map<string, RenderBatch>;

/**
Expand Down Expand Up @@ -72,7 +72,7 @@ describe('EventBatchRenderer', () => {
*/
function setupAndRender(events: LogEvent[], viewport: ViewportState): void {
const categories = new Set(batches.keys());
rectangleManager = new RectangleManager(events, categories);
rectangleManager = new RectangleCache(events, categories);
renderer = new EventBatchRenderer(container, batches);

const { visibleRects, buckets } = rectangleManager.getCulledRectangles(viewport);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
* Copyright (c) 2025 Certinia Inc. All rights reserved.
*/

import { MeasurementManager } from '../optimised/measurement/MeasurementManager.js';
import { MeasurementState } from '../optimised/measurement/MeasurementState.js';

describe('MeasurementManager', () => {
let manager: MeasurementManager;
describe('MeasurementState', () => {
let manager: MeasurementState;

beforeEach(() => {
manager = new MeasurementManager();
manager = new MeasurementState();
});

describe('initial state', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import type { LogEvent } from 'apex-log-parser';
import { MinimapDensityQuery } from '../optimised/minimap/MinimapDensityQuery.js';
import type { PrecomputedRect } from '../optimised/RectangleManager.js';
import type { PrecomputedRect } from '../optimised/RectangleCache.js';
import { TemporalSegmentTree } from '../optimised/TemporalSegmentTree.js';

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import type { LogEvent } from 'apex-log-parser';
import * as PIXI from 'pixi.js';
import type { PrecomputedRect } from '../optimised/RectangleManager.js';
import type { PrecomputedRect } from '../optimised/RectangleCache.js';
import { SearchHighlightRenderer } from '../optimised/search/SearchHighlightRenderer.js';
import type { EventNode, ViewportState } from '../types/flamechart.types.js';
import type { SearchCursor, SearchMatch } from '../types/search.types.js';
Expand Down
Loading
Loading