refactor: consolidate color utilities and require theme colors in pipeline#753
Merged
lcottercertinia merged 1 commit intocertinia:mainfrom Apr 14, 2026
Conversation
…back Move blendWithBackground, cssColorToPixi, and DEFAULT_BACKGROUND_COLOR from BucketColorResolver to ColorUtils, making ColorUtils the single module for all color conversion and blending. Make batchColors required across the rendering pipeline (resolveColor, getCulledRectangles, TemporalSegmentTree.query, legacyCullRectangles, resolveBucketSearchColor) so theme colors are always explicitly passed rather than silently falling back to hardcoded defaults. Remove unused setBatchColors methods and cached batchColors field from both TemporalSegmentTree and RectangleCache.
lcottercertinia
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Consolidate color conversion utilities into
ColorUtilsand makebatchColors(theme colors) a required parameter across the rendering pipeline. Previously, if theme colors weren't passed, the code silently fell back to hardcodedCATEGORY_COLORSdefaults — rendering the timeline with wrong colors instead of the user's theme without any indication. This refactor makes that a compile-time error.🛠️ Changes made
blendWithBackground,cssColorToPixi, andDEFAULT_BACKGROUND_COLORfromBucketColorResolvertoColorUtils, makingColorUtilsthe single module for all color conversion and blendingCATEGORY_COLORSconstant fromBucketColorResolver— theme-providedbatchColorsis now the sole color sourcebatchColorsrequired inresolveColor,getCulledRectangles,TemporalSegmentTree.query,legacyCullRectangles, andresolveBucketSearchColorsetBatchColorsmethods and cachedbatchColorsfield fromTemporalSegmentTreeandRectangleCacheblendWithBackgroundandcssColorToPixiinColorUtils.test.ts🧩 Type of change (check all applicable)
✅ Tests added?
📚 Docs updated?