build: copy package docs only at vsix package time#796
Open
lukecotter wants to merge 2 commits into
Open
Conversation
- replace the three inline `tsc --noemit` calls (build:dev, build:dev:fast, lint) with one `tsgo -b` over project references; swc/rolldown stay transpile-only - wire references: apex-log-parser becomes composite (emitDeclarationOnly), log-viewer/lana reference it, new root solution tsconfig — enables incremental caching - gate prod `build` on `typecheck` and run it in `lint` (preserves CI PR gate); add @typescript/native-preview (tsgo), ~7.7x faster cold than tsc
- move the CHANGELOG/LICENSE/README copy out of rollup/rolldown into scripts/copy-package-docs.mjs, run from lana's vscode:prepublish — docs are no longer regenerated on every dev build/watch - drop the redundant `rm -rf lana/out` from rolldown scripts (its cleanDir already clears output); keep it for rollup which has no native clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
rollup.config.mjsandrolldown.config.tscopyCHANGELOG.md/LICENSE.txt/README.mdintolana/on every build/watch, but those files are only needed when packaging the.vsix(lana/.vscodeignoreincludes exactly them, and the copies are gitignored artifacts). This moves the copy to package time so dev builds stay clean and fast.🛠️ Changes made (this PR's commit only)
{ src: ['CHANGELOG.md','LICENSE.txt','README.md'], dest: 'lana' }target from bothrollup.config.mjsandrolldown.config.ts(the siblinglog-viewer/out → lana/outruntime copy stays).scripts/copy-package-docs.mjs(ESM, parallelcopyFileviaPromise.all) and acopy:package-docsscript; run it fromlana'svscode:prepublishsovscegets the docs at package time.rm -rf lana/outfrom the rolldown scripts (cleanDir: truealready clears output); keep it for rollup, which has no native clean.🧩 Type of change (check all applicable)
🔗 Related Issues
✅ Tests added?
📚 Docs updated?
Test plan
build:dev(rollup) andbuild:dev:fast(rolldown) no longer regenerate thelana/docs;lana/outfully populatedvsce package --no-dependenciessucceeds with README/CHANGELOG/LICENSE present in the.vsixpnpm lintandpnpm test(886/886) green