Fix MaceDMG reliability with Killaura, spear hits, and AttributeSwap swaps + spear aura fix#8
Open
Altidias wants to merge 3 commits into
Open
Fix MaceDMG reliability with Killaura, spear hits, and AttributeSwap swaps + spear aura fix#8Altidias wants to merge 3 commits into
Altidias wants to merge 3 commits into
Conversation
…the held item for a PIERCING_WEAPON component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaceDMG only smashed when your crosshair was on the target and when
itsattacklistener happened to run after a weapon swap, so it was unreliable with Killaura, with spears, and alongside AttributeSwap. Separately, aura couldn't hit with a spear at all, because it used the wrong attack method.MC.hitResult == ENTITYgate. ThePlayerAttacksEntityEventalready means an entity is being hit, requiring the crosshair on it
suppressed the smash for Killaura (which attacks via
gameMode.attackwithout you looking at the target).
doSmash()guarded by a once-per-tickcheck (
lastSmashTick), so it can be triggered externally withoutdouble-firing.
LeftClickListenerso the swap also fires on the attackinput, covering spear / left-click hits that don't go through the normal
attack path.
maceDmgHack.doSmash()so the smash lands rightafter the mace is equipped.
PIERCING_WEAPONcomponent, attacks route through
gameMode.piercingAttack()(the STABaction packet) instead of
gameMode.attack().