Merge pull request #5057 from cfpb/instituions_api-year-selector

Disassociate HMDA Dashboard from Time Guard Settings.

Author: lchen-2101

common/src/main/scala/hmda/api/http/directives/CreateFilingAuthorization.scala

@@ -27,4 +27,11 @@ object CreateFilingAuthorization {
     if (Filer.checkQuarterlyYear(rulesConfig)(year)) successful
     else complete((BadRequest, ErrorResponse(BadRequest.intValue, "The provided year is not available", path)))
   }
+
+  def isInstitutionsYearAllowed(allowed: Boolean)(successful: Route): Route = extractMatchedPath { path =>
+    if (allowed) successful
+    else complete((BadRequest, ErrorResponse(BadRequest.intValue, "The provided year is not available via the institutions api", path)))
+  }
+
+
 }

institutions-api/src/main/scala/hmda/institution/api/http/InstitutionQueryHttpApi.scala

@@ -46,7 +46,7 @@ private class InstitutionQueryHttpApi(config: Config)(implicit ec: ExecutionCont
   private val institutionByIdPath =
     path("institutions" / Segment / "year" / IntNumber) { (lei, year) =>
       (extractUri & get) { uri =>
-        isQuarterlyYearAllowed(year) {
+        isInstitutionsYearAllowed(yearsAvailable.contains(year.toString)){
 
           val defaultRepo = institutionRepositories(institutionConfig.getString("defaultYear"))
           val fInstitution = institutionRepositories.getOrElse(year.toString, defaultRepo).findById(lei)
@@ -72,7 +72,7 @@ private class InstitutionQueryHttpApi(config: Config)(implicit ec: ExecutionCont
   private val institutionByDomainPath =
     path("institutions" / "year" / IntNumber) { year =>
       (extractUri & get) { uri =>
-        isFilingAllowed(year, None) {
+        isInstitutionsYearAllowed(yearsAvailable.contains(year.toString)){
           parameter('domain.as[String]) { domain =>
             val f = findByEmail(domain, year.toString)
             completeInstitutionsFuture(f, uri)

institutions-api/src/main/scala/hmda/institution/query/InstitutionComponent.scala

@@ -75,8 +75,8 @@ trait InstitutionComponent {
         .result
     )
 
-    def createSchema() = db.run(table.schema.create)
-    def dropSchema()   = db.run(table.schema.drop)
+    def createSchema() = db.run(table.schema.createIfNotExists)
+    def dropSchema()   = db.run(table.schema.dropIfExists)
   }
 
   val institutionConfig: Config = ConfigFactory.load().getConfig("hmda.institution")

institutions-api/src/test/resources/application-createschema.conf

@@ -44,6 +44,8 @@ cassandra-snapshot-store {
 hmda {
   institution {
     createSchema = false
+    yearsAvailable = "2018,2019,2020,2021,2022"
+    defaultYear = "2022"
   }
 
   rules {