Skip to content

Delete mlar by submission id rather than lei #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PatrickGoRaft merged 5 commits into from
Apr 30, 2026
Merged

Delete mlar by submission id rather than lei #5111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd86d8c
delete mlar by submission id rather than lei to account for instituti…
kgudel Mar 25, 2026
92ee0b7
add prints for debugging
kgudel Mar 25, 2026
a07c269
add prints for debugging
kgudel Mar 25, 2026
e2fdbb6
condense like statement to fix syntax
kgudel Mar 26, 2026
4d86f5d
remove unneccessary year specification as mlar tables are by year
kgudel Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions common/src/main/scala/hmda/query/repository/ModifiedLarRepository.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@ class ModifiedLarRepository(databaseConfig: DatabaseConfig[JdbcProfile]) {
db.run(
sqlu"DELETE FROM #${fetchYearTable(submissionId.period.year.toInt)} WHERE UPPER(lei) = ${submissionId.lei.toUpperCase} and filing_year = ${submissionId.period.year.toInt}"
)

/**
* Deletes entries in the Modified LAR table by their Submission ID
* This is to account for the change from S303 to Q303
* @param submissionId
* @return the number of rows removed
*/
def deleteBySubmissionID(submissionId: SubmissionId): Future[Int] = {
val likeStatement = s"${submissionId.lei}-%"
db.run(
sqlu"""DELETE FROM #${fetchYearTable(period.toInt)} WHERE submission_id LIKE $likeStatement"""
Copy link
Copy Markdown
Contributor

@lchen-2101 lchen-2101 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to just delete by the lei only? since the mlar tables themselves are already period specific?

Copy link
Copy Markdown
Contributor

@PatrickGoRaft PatrickGoRaft Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KennethGudel

)
}

/**
* Inserts Modified Loan Application Register data that has been enhanced with Census information via the tract map
Expand Down
3 changes: 2 additions & 1 deletion modified-lar/src/main/scala/hmda/publication/lar/publication/ModifiedLarPublisher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ object ModifiedLarPublisher {
.withAttributes(S3Attributes.settings(s3Settings))

def removeLei: Future[Int] =
modifiedLarRepo.deleteByLei(submissionId)
modifiedLarRepo.deleteBySubmissionID(submissionId)

val mlarSource: Source[ModifiedLoanApplicationRegister, NotUsed] =
readRawData(system)(submissionId)
Expand Down Expand Up @@ -175,6 +175,7 @@ object ModifiedLarPublisher {

val finalResult: Future[Unit] = for {
_ <- if (regenerateMlar)
removeLei
graphWithS3AndPG.run()
else if (isGenerateBothS3Files) {
removeLei
Expand Down
Loading