sdk/node: accept amounts as strings

Closes #3680

Author: Keith Rarick <kr@xph.us>
Date: Fri May 11 13:14:14 2018 -0700
upstream:77f78350bc59db23b041987c645428082ff8e21a

Author: kr

src/api/transactions.ts

@@ -61,20 +61,21 @@ export class TransactionBuilder {
    *
    * @param {Object} params - Action parameters.
    * @param {String} params.flavorId - ID of flavor to be issued.
-   * @param {Number|BigNumber} params.amount - Amount of the flavor to be issued.
+   * @param {Number|String|BigNumber} params.amount - Amount of the flavor to be issued.
    * @param {String} params.destinationAccountId - Account ID specifying the
    *   account controlling the flavor.
    * @param {Object} params.tokenTags - Tags to add to the receiving tokens.
    * @param {Object} params.actionTags - Tags to add to the action.
    */
   public issue(params: {
     flavorId: string
-    amount: number | BigNumber
+    amount: number | string | BigNumber
     destinationAccountId: string
     tokenTags?: object
     actionTags?: object
   }) {
     validate(params, 'IssueActionSchema')
+    params.amount = new BigNumber(params.amount)
     this.actions.push(Object.assign({}, params, { type: 'issue' }))
   }
 
@@ -85,20 +86,21 @@ export class TransactionBuilder {
    * @param {String} params.sourceAccountId - Account ID specifying the account
    *   controlling the flavor.
    * @param {String} params.flavorId - ID of flavor to be retired.
-   * @param {Number|BigNumber} params.amount - Amount of the flavor to be retired.
+   * @param {Number|String|BigNumber} params.amount - Amount of the flavor to be retired.
    * @param {String} params.filter - Token filter string, see {@link https://dashboard.seq.com/docs/filters}.
    * @param {Array<String|Number>} params.filterParams - Parameter values for filter string (if needed).
    * @param {Object} params.actionTags - Tags to add to the action.
    */
   public retire(params: {
     sourceAccountId: string
     flavorId: string
-    amount: number | BigNumber
+    amount: number | string | BigNumber
     filter?: string
     filterParams?: object
     actionTags?: object
   }) {
     validate(params, 'RetireActionSchema')
+    params.amount = new BigNumber(params.amount)
     this.actions.push(Object.assign({}, params, { type: 'retire' }))
   }
 
@@ -110,7 +112,7 @@ export class TransactionBuilder {
    * @param {String} params.sourceAccountId - Account ID specifying the account
    *   controlling the flavor.
    * @param {String} params.flavorId - ID of flavor to be transferred.
-   * @param {Number|BigNumber} params.amount - Amount of the flavor to be transferred.
+   * @param {Number|String|BigNumber} params.amount - Amount of the flavor to be transferred.
    * @param {String} params.destinationAccountId - Account ID specifying the
    *   account controlling the flavor.
    * @param {String} params.filter - Token filter string, see {@link https://dashboard.seq.com/docs/filters}.
@@ -121,14 +123,15 @@ export class TransactionBuilder {
   public transfer(params: {
     sourceAccountId: string
     flavorId: string
-    amount: number | BigNumber
+    amount: number | string | BigNumber
     destinationAccountId: string
     filter?: string
     filterParams?: object
     tokenTags?: object
     actionTags?: object
   }) {
     validate(params, 'TransferActionSchema')
+    params.amount = new BigNumber(params.amount)
     this.actions.push(Object.assign({}, params, { type: 'transfer' }))
   }
 }

src/validate.ts

@@ -79,6 +79,7 @@ ajv.addSchema(
             minimum: 0,
             maximum: Number.MAX_SAFE_INTEGER,
           },
+          { type: 'string' },
           { type: 'object' },
         ],
       },
@@ -105,6 +106,7 @@ ajv.addSchema(
             minimum: 0,
             maximum: Number.MAX_SAFE_INTEGER,
           },
+          { type: 'string' },
           { type: 'object' },
         ],
       },
@@ -128,6 +130,7 @@ ajv.addSchema(
             minimum: 0,
             maximum: Number.MAX_SAFE_INTEGER,
           },
+          { type: 'string' },
           { type: 'object' },
         ],
       },

test/transactions.ts

@@ -125,6 +125,22 @@ describe('Transaction', () => {
       assert.equal(amount, tx.actions[0].amount.toString())
     })
 
+    it('handles large numbers as strings', async () => {
+      const gold = await createFlavor('gold')
+      const alice = await createAccount('alice')
+      const amount = '9223372036854775807'
+
+      const tx = await client.transactions.transact(builder => {
+        builder.issue({
+          flavorId: gold.id,
+          amount: amount,
+          destinationAccountId: alice.id,
+        })
+      })
+
+      assert.equal(amount, tx.actions[0].amount.toString())
+    })
+
     it('throws an error at the amount boundary', async () => {
       const gold = await createFlavor('gold')
       const alice = await createAccount('alice')