sdk/node: prevent v1.x params for queries

Closes #3333

Author: Dominic Dagradi <ddagradi@gmail.com>
Date: Mon Apr 16 10:21:10 2018 -0700
upstream:d7557e1015446c554ea453311b7fc9dd2367ef82

Author: dominic

src/query.ts

@@ -6,6 +6,7 @@ if (typeof (Symbol as any).asyncIterator === 'undefined') {
 import { Client } from './client'
 import { Page } from './page'
 import { PageParams } from './types'
+import { validate } from './validate'
 
 /**
  * A query for Sequence items.
@@ -20,7 +21,11 @@ export class Query<QueryParamType> {
     private itemName: string,
     private method: string,
     private queryParams?: QueryParamType
-  ) {}
+  ) {
+    if (queryParams) {
+      validate(queryParams, 'QueryParamsSchema')
+    }
+  }
 
   /**
    * Retrieve a page of results.

src/validate.ts

@@ -46,3 +46,24 @@ ajv.addSchema(
   },
   'UpdateTagsSchema'
 )
+
+ajv.addSchema(
+  {
+    type: 'object',
+    properties: {
+      filter: { type: 'string' },
+      filterParams: {
+        type: 'array',
+        items: {
+          anyOf: [{ type: 'string' }, { type: 'number' }],
+        },
+      },
+      pageSize: { type: 'number' },
+      cursor: { type: 'string' },
+      summary: { type: 'boolean' },
+      groupBy: { type: 'array', items: { type: 'string' } },
+    },
+    additionalProperties: false,
+  },
+  'QueryParamsSchema'
+)

test/validateSchema.js

@@ -73,4 +73,36 @@ describe('Schemas', () => {
       })
     })
   })
+
+  describe('Query', () => {
+    it('rejects list with after', () => {
+      try {
+        client.accounts.list({ after: 'foo' }).all()
+      } catch (err) {
+        expect(err.message).to.contain("should NOT have additional properties '.after'")
+        return
+      }
+      assert(false, 'should not accept `after` field')
+    })
+
+    it('rejects sum with sum by', () => {
+      try {
+        client.actions.sum({ sumBy: ['foo'] }).all()
+      } catch (err) {
+        expect(err.message).to.contain("should NOT have additional properties '.sumBy'")
+        return
+      }
+      assert(false, 'should not accept `sumBy` field')
+    })
+
+    it('rejects list with start time', () => {
+      try {
+        client.transactions.list({ startTime: 0 }).all()
+      } catch (err) {
+        expect(err.message).to.contain("should NOT have additional properties '.startTime'")
+        return
+      }
+      assert(false, 'should not accept `startTime` field')
+    })
+  })
 })