sdk/node: re-introduce custom baseUrl support

When run outside of a node process (i.e. in the browser),
the SEQADDR environment variable is not a consistent method
for setting a custom API URL.

Closes #4682

Author: Dominic Dagradi <ddagradi@gmail.com>
Date: Tue Aug 14 16:39:13 2018 -0700
upstream:b912a75b3497b7b831609684038a21fb592b17da

Author: dominic

CHANGELOG.md

@@ -1,9 +1,14 @@
 # Sequence Node SDK changelog
 
+## 2.2.1 (??????)
+
+* Added support for setting a custom API URL when run outside
+  of a Node process.
+
 ## 2.2.0 (20180808)
 
 * Added `updateTags` to `Action`.
-* Added support for dynamically addressing different API hosts for 
+* Added support for dynamically addressing different API hosts for
   individual ledgers. Internal APIs only, works automatically.
 
 ## 2.1.0 (20180516)

src/connection.ts

@@ -93,6 +93,7 @@ export class Connection {
   public retryBaseDelayMs = 40
   public retryMaxDelayMs = 20000
   public credential?: string
+  public baseUrl: string
   public agent?: Agent
   public ledgerName: string
   private ledgerUrl: string
@@ -107,6 +108,7 @@ export class Connection {
    * @returns {Client}
    */
   constructor(ledgerName: string, credential?: string, agent?: Agent) {
+    this.baseUrl = 'https://' + (process.env.SEQADDR || 'api.seq.com')
     this.ledgerName = ledgerName
     this.credential = credential
     this.agent = agent
@@ -285,7 +287,7 @@ export class Connection {
 
   public async getLedgerUrl() {
     const body = (await this.requestRaw(
-      'https://' + (process.env.SEQADDR || 'api.seq.com') + '/hello',
+      this.baseUrl + '/hello',
       {
         ledger_name: this.ledgerName,
       },

test/errors.ts

@@ -116,7 +116,6 @@ describe('Errors', () => {
   })
 
   describe('no server', () => {
-    const unauthedClient = testHelpers.constructClient()
     const oldAddr = process.env.SEQADDR
 
     let err: any
@@ -125,6 +124,7 @@ describe('Errors', () => {
       process.env.SEQADDR = 'localhost:12345'
 
       try {
+        const unauthedClient = testHelpers.constructClient()
         await unauthedClient.accounts.list().page()
       } catch (e) {
         err = e