sdk/node: throw validation error for large integers

Closes #3604

Author: Dominic Dagradi <ddagradi@gmail.com>
Date: Sun May 6 14:26:29 2018 -0700
upstream:b9816a2764f3cafce9da2577d3f08abd2f2d73e3

Author: dominic

src/validate.ts

@@ -73,7 +73,14 @@ ajv.addSchema(
     properties: {
       actionTags: { type: 'object' },
       amount: {
-        anyOf: [{ type: 'number' }, { type: 'object' }],
+        anyOf: [
+          {
+            type: 'number',
+            minimum: 0,
+            maximum: Number.MAX_SAFE_INTEGER,
+          },
+          { type: 'object' },
+        ],
       },
       destinationAccountId: { type: 'string' },
       filter: { type: 'string' },
@@ -92,7 +99,14 @@ ajv.addSchema(
     properties: {
       actionTags: { type: 'object' },
       amount: {
-        anyOf: [{ type: 'number' }, { type: 'object' }],
+        anyOf: [
+          {
+            type: 'number',
+            minimum: 0,
+            maximum: Number.MAX_SAFE_INTEGER,
+          },
+          { type: 'object' },
+        ],
       },
       destinationAccountId: { type: 'string' },
       flavorId: { type: 'string' },
@@ -108,7 +122,14 @@ ajv.addSchema(
     properties: {
       actionTags: { type: 'object' },
       amount: {
-        anyOf: [{ type: 'number' }, { type: 'object' }],
+        anyOf: [
+          {
+            type: 'number',
+            minimum: 0,
+            maximum: Number.MAX_SAFE_INTEGER,
+          },
+          { type: 'object' },
+        ],
       },
       filter: { type: 'string' },
       filterParams: { type: 'array' },

test/transactions.ts

@@ -96,7 +96,7 @@ describe('Transaction', () => {
       const alice = await createAccount('alice')
       const amount = '9223372036854775808'
 
-      expect(
+      return expect(
         client.transactions.transact(builder => {
           builder.issue({
             flavorId: gold.id,
@@ -106,6 +106,22 @@ describe('Transaction', () => {
         })
       ).to.be.rejectedWith('SEQ706')
     })
+
+    it('throws an error when losing precision', async () => {
+      const gold = await createFlavor('gold')
+      const alice = await createAccount('alice')
+      const amount = 9999999999999999
+
+      return expect(
+        client.transactions.transact(builder => {
+          builder.issue({
+            flavorId: gold.id,
+            amount,
+            destinationAccountId: alice.id,
+          })
+        })
+      ).to.be.rejectedWith('should be <= 9007199254740991')
+    })
   })
 
   describe('Transfer', () => {