sdk/node: prevent v1.x params for flavors.create

While Flavors have always been a forward-looking endpoint,
users will attempt to find/replace `assets` with `flavors` and
we should catch the bad parameter errors in the same
way as `account`.

Closes #3329

Author: Dominic Dagradi <ddagradi@gmail.com>
Date: Mon Apr 16 10:15:39 2018 -0700
upstream:8ec4fbf18396efea3fa8623ca936a7647158043d

Author: dominic

src/api/accounts.ts

@@ -66,7 +66,7 @@ export const accountsAPI = (client: Client) => {
      * @returns {Promise<Account>} Newly created account.
      */
     create: (params: CreateRequest) =>
-      client.request('/create-account', params, 'CreateAccountSchema'),
+      client.request('/create-account', params, 'CreateAccountOrFlavorSchema'),
 
     /**
      * Update account tags.

src/api/flavors.ts

@@ -64,7 +64,8 @@ export const flavorsAPI = (client: Client) => {
      * @param {module:FlavorsApi~createRequest} params - Parameters for flavor creation.
      * @returns {Promise<Flavor>} Newly created flavor.
      */
-    create: (params: CreateRequest) => client.request('/create-flavor', params),
+    create: (params: CreateRequest) =>
+      client.request('/create-flavor', params, 'CreateAccountOrFlavorSchema'),
 
     /**
      * Update flavor tags.

src/validate.ts

@@ -33,5 +33,5 @@ ajv.addSchema(
     },
     additionalProperties: false,
   },
-  'CreateAccountSchema'
+  'CreateAccountOrFlavorSchema'
 )

test/validateSchema.js

@@ -20,6 +20,32 @@ describe('Schemas', () => {
         expect(err.message).to.contain("should NOT have additional properties '.alias'")
       })
     })
+
+    it('rejects creation with keys', () => {
+      return client.accounts.create({ keys: [1,2,3] })
+      .then(() => assert(false, 'should not accept `keys` field'))
+      .catch(err => {
+        expect(err.message).to.contain("should NOT have additional properties '.keys'")
+      })
+    })
+  })
+
+  describe('Flavor', () => {
+    it('rejects creation with alias', () => {
+      return client.flavors.create({ alias: 'foo' })
+      .then(() => assert(false, 'should not accept `alias` field'))
+      .catch(err => {
+        expect(err.message).to.contain("should NOT have additional properties '.alias'")
+      })
+    })
+
+    it('rejects creation with keys', () => {
+      return client.flavors.create({ keys: [1,2,3] })
+      .then(() => assert(false, 'should not accept `keys` field'))
+      .catch(err => {
+        expect(err.message).to.contain("should NOT have additional properties '.keys'")
+      })
+    })
   })
 
   describe('Key', () => {