sdk/node: prevent v1.x params for tag updating

Closes #3331

Author: Dominic Dagradi <ddagradi@gmail.com>
Date: Mon Apr 16 10:17:37 2018 -0700
upstream:6237025e5908eef83f260feac5e5908f106b7610

Author: dominic

src/api/accounts.ts

@@ -75,7 +75,7 @@ export const accountsAPI = (client: Client) => {
      * @returns {Promise<Object>} Success message.
      */
     updateTags: (params: UpdateTagsRequest) =>
-      client.request('/update-account-tags', params),
+      client.request('/update-account-tags', params, 'UpdateTagsSchema'),
 
     /**
      * Query a list of accounts matching the specified query.

src/api/flavors.ts

@@ -74,7 +74,7 @@ export const flavorsAPI = (client: Client) => {
      * @returns {Promise<Object>} Success message.
      */
     updateTags: (params: UpdateTagsRequest) =>
-      client.request('/update-flavor-tags', params),
+      client.request('/update-flavor-tags', params, 'UpdateTagsSchema'),
 
     /**
      * Query a list of flavors matching the specified query.

src/validate.ts

@@ -35,3 +35,14 @@ ajv.addSchema(
   },
   'CreateAccountOrFlavorSchema'
 )
+
+ajv.addSchema(
+  {
+    properties: {
+      id: { type: 'string' },
+      tags: { type: 'object' },
+    },
+    additionalProperties: false,
+  },
+  'UpdateTagsSchema'
+)

test/validateSchema.js

@@ -21,6 +21,14 @@ describe('Schemas', () => {
       })
     })
 
+    it('rejects tag updates with alias', () => {
+      return client.accounts.updateTags({alias: 'foo', tags: {foo: 'bar'}})
+      .then(() => assert(false, 'should not accept `alias` field'))
+      .catch(err => {
+        expect(err.message).to.contain("should NOT have additional properties '.alias'")
+      })
+    })
+
     it('rejects creation with keys', () => {
       return client.accounts.create({ keys: [1,2,3] })
       .then(() => assert(false, 'should not accept `keys` field'))
@@ -39,6 +47,14 @@ describe('Schemas', () => {
       })
     })
 
+    it('rejects tag updates with alias', () => {
+      return client.flavors.updateTags({alias: 'foo', tags: {foo: 'bar'}})
+      .then(() => assert(false, 'should not accept `alias` field'))
+      .catch(err => {
+        expect(err.message).to.contain("should NOT have additional properties '.alias'")
+      })
+    })
+    
     it('rejects creation with keys', () => {
       return client.flavors.create({ keys: [1,2,3] })
       .then(() => assert(false, 'should not accept `keys` field'))