fix: fall back to GET when APKINDEX HEAD is unsupported#2282
Open
arpitjain099 wants to merge 1 commit into
Open
fix: fall back to GET when APKINDEX HEAD is unsupported#2282arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
arpitjain099
force-pushed
the
fix/apkindex-head-fallback
branch
3 times, most recently
from
864afa0 to
df664e5
Compare
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
fix/apkindex-head-fallback
branch
from
df664e5 to
ea2aa6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Alpine registries reject HEAD requests for APKINDEX.tar.gz with 405, which currently makes index resolution fail before we ever fetch the index.
This change treats 405 and 501 from the HEAD probe as unsupported-method responses and falls back to fetching and parsing the index via GET without etag-based HEAD caching. Other non-200 statuses still fail as before.
I also added a regression test that simulates HEAD returning 405 while GET succeeds.
Fixes #2251
Verification: