fix: use content-disposition filename for fetched keys#2283
Open
arpitjain099 wants to merge 1 commit into
Open
fix: use content-disposition filename for fetched keys#2283arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
arpitjain099
force-pushed
the
fix/key-content-disposition
branch
3 times, most recently
from
08a7380 to
58b9e85
Compare
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
fix/key-content-disposition
branch
from
58b9e85 to
6a41700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a key URL does not include the real key filename in its path (for example
/keyon Forgejo/Gitea), apko currently writes the fetched key to that path basename. That breaks signature verification because APKINDEX signatures reference the actual key filename.This change uses the response
Content-Dispositionfilename (includingfilename*values) when it is present, and falls back to the URL basename otherwise.I also added a regression test that serves a key from
/keywith aContent-Dispositionfilename and verifies the key is written under the header-provided name.Fixes #2252
Verification: