Flip the logic

egibs · egibs · commit 5e1d646465bc · 2025-05-27T09:19:59.000-05:00
Signed-off-by: egibs &lt;20933572+egibs@users.noreply.github.com&gt;
diff --git a/pkg/action/scan.go b/pkg/action/scan.go
@@ -632,10 +632,10 @@ func processArchive(ctx context.Context, c malcontent.Config, rfs []fs.FS, archi
 	if err != nil {
 		// Avoid failing an entire scan when encountering problematic archives
 		// e.g., joblib_0.8.4_compressed_pickle_py27_np17.gz: not a valid gzip archive
-		if c.ExitExtraction {
-			return nil, fmt.Errorf("extract to temp: %w", err)
+		if !c.ExitExtraction {
+			return nil, nil
 		}
-		return nil, nil
+		return nil, fmt.Errorf("extract to temp: %w", err)
 	}
 	// Ensure that tmpRoot is removed before returning if created successfully
 	defer func() {

Original file line number	Diff line number	Diff line change
`@@ -632,10 +632,10 @@ func processArchive(ctx context.Context, c malcontent.Config, rfs []fs.FS, archi`
`632`	`632`	`if err != nil {`
`633`	`633`	`// Avoid failing an entire scan when encountering problematic archives`
`634`	`634`	`// e.g., joblib_0.8.4_compressed_pickle_py27_np17.gz: not a valid gzip archive`
`635`		`- if c.ExitExtraction {`
`636`		`- return nil, fmt.Errorf("extract to temp: %w", err)`
	`635`	`+ if !c.ExitExtraction {`
	`636`	`+ return nil, nil`
`637`	`637`	`}`
`638`		`- return nil, nil`
	`638`	`+ return nil, fmt.Errorf("extract to temp: %w", err)`
`639`	`639`	`}`
`640`	`640`	`// Ensure that tmpRoot is removed before returning if created successfully`
`641`	`641`	`defer func() {`