Add nil checks for slice pointers; filter invalid overrides from reports#1031
Merged
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
approved these changes
Jul 2, 2025
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds guards for the new syscalls/pledges/caps slice pointers and finally refactors the override behavior to filter out matching rules that either reference invalid rule names or rules that were not part of the matching rules for a file.
This has the effect of removing seemingly-legitimate rule matches for a handful of samples, but these are the override rules that were matching (usually these would be prefixed with
false-positives/but we had a handful of overrides scattered elsewhere).