Clean up some code and consolidate variables#1139
Merged
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
general-cleanup
branch
from
b21f87b to
84931f2
Compare
antitree
approved these changes
Sep 26, 2025
antitree
left a comment
antitree
left a comment
Contributor
There was a problem hiding this comment.
Built it locally and investigated some issues that Claude identified but I don't see any meaningful issues.
egibs
commented
Sep 26, 2025
Signed-off-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates some of the
diff.govariables since we do the same declarations for both the source and destination variables. We also never usedaction.goand there were a couple of cases where we increased complexity ofifstatements when we could just have an earlier, separate check to return early.refresh.gowas still usingfilepath.Walkinstead ofWalkDirwith the latter being much more efficient even though we aren't enumerating thousands of paths when discovering test data.These changes shouldn't have any functional impact (i.e.,
make refresh-sample-testdatais a NOP).