Skip to content

Handle file contents/checksum only when generating a report #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egibs merged 2 commits into from
Nov 10, 2025
Merged

Handle file contents/checksum only when generating a report #1209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01cd548
Handle file contents/checksum only when generating a report
egibs Nov 10, 2025
023d195
Merge branch 'main' into move-file-contents-checksum
egibs Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions pkg/action/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,6 @@ func scanSinglePath(ctx context.Context, c malcontent.Config, path string, ruleF
})
buf := readPool.Get(readBuffer) //nolint:nilaway // the buffer pool is created above

var fc bytes.Buffer
_, err = io.CopyBuffer(&fc, io.LimitReader(f, maxBytes), buf)
if err != nil {
return nil, err
}

h := sha256.New()
_, err = h.Write(fc.Bytes())
if err != nil {
return nil, err
}
checksum := fmt.Sprintf("%x", h.Sum(nil))

mime := "<unknown>"
kind, err := programkind.File(ctx, path)
if err != nil && !interactive(c) {
Expand Down Expand Up @@ -152,6 +139,20 @@ func scanSinglePath(ctx context.Context, c malcontent.Config, path string, ruleF
return fr, nil
}

// Only retrieve the file's contents and calculate its checksum if we need to generate a report
var fc bytes.Buffer
_, err = io.CopyBuffer(&fc, io.LimitReader(f, maxBytes), buf)
if err != nil {
return nil, err
}

h := sha256.New()
_, err = h.Write(fc.Bytes())
if err != nil {
return nil, err
}
checksum := fmt.Sprintf("%x", h.Sum(nil))

fr, err := report.Generate(ctx, path, mrs, c, archiveRoot, logger, fc.Bytes(), size, checksum, kind, risk)
if err != nil {
return nil, NewFileReportError(err, path, TypeGenerateError)
Expand Down